Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend wrapper APIs for VCS #12

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Sep 27, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2023
@Moopli Moopli force-pushed the big-refactor branch 3 times, most recently from c9d4646 to cd656e6 Compare September 27, 2023 15:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (24e819a) 85.41% compared to head (b92b3a5) 85.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   85.41%   85.58%   +0.17%     
==========================================
  Files          78       82       +4     
  Lines        8314     8387      +73     
==========================================
+ Hits         7101     7178      +77     
+ Misses        889      884       -5     
- Partials      324      325       +1     
Files Coverage Δ
doc/util/jwkkid/kid_creator.go 83.43% <100.00%> (-1.38%) ⬇️
wrapper/localsuite/creator.go 100.00% <100.00%> (ø)
wrapper/localsuite/encrypter.go 100.00% <100.00%> (ø)
wrapper/localsuite/multisigner.go 100.00% <100.00%> (ø)
wrapper/localsuite/signer.go 100.00% <100.00%> (ø)
wrapper/localsuite/suite.go 100.00% <100.00%> (ø)
wrapper/localsuite/wrapper.go 95.83% <100.00%> (ø)
wrapper/localsuite/localsuite.go 85.00% <85.00%> (ø)
doc/jose/jwk/jwksupport/jwk.go 92.85% <91.78%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moopli Moopli force-pushed the big-refactor branch 4 times, most recently from dd6e967 to eee2b6a Compare September 27, 2023 23:19
PR also cleans up duplication in public key parsing APIs

Signed-off-by: Filip Burlacu <[email protected]>
@Moopli Moopli marked this pull request as ready for review September 28, 2023 05:33
@Moopli Moopli merged commit 638bd66 into trustbloc:main Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants